Remove XCM SafeCallFilter for chains using Weights::v2 #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joepetrowski
approved these changes
Apr 24, 2024
system-parachains/bridge-hubs/bridge-hub-kusama/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
system-parachains/bridge-hubs/bridge-hub-polkadot/src/xcm_config.rs
Outdated
Show resolved
Hide resolved
10 tasks
acatangiu
force-pushed
the
remove-safe-call-filter
branch
from
acb9729
to
51179d7
Compare
Remove `SafeCallFilter` from system chains as they all now use Weights::v2 which already accounts for call PoV size. This effectively removes artificial limitations on what users can`XCM::Transact` on these chains (blockspace limitations are still upheld).
acatangiu
force-pushed
the
remove-safe-call-filter
branch
from
51179d7
to
3aa6ef3
Compare
ggwpez
approved these changes
May 6, 2024
muharem
approved these changes
May 6, 2024
…ve-safe-call-filter
…ve-safe-call-filter
|
/merge |
|
Enabled Available commands
For more information see the documentation |
auto-merge was automatically disabled
May 7, 2024 10:56
Head branch was pushed to by a user without write access
|
/merge |
fellowship-merge-bot
bot
merged commit d57f962
into
polkadot-fellows:main
35 of 36 checks passed
|
Enabled Available commands
For more information see the documentation |
52 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove
SafeCallFilterfrom system chains as they all now use Weights::v2 which already accounts for call PoV size. This effectively removes artificial limitations on what users canXCM::Transacton these chains (blockspace limitations are still upheld).Fixes #273