Short benchmarking in CI with frame-omni-bencher + extract chain-spec-builder stuff to get_preset
#379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
bkontur
force-pushed
the
bko-short-benchmarks-get_preset
branch
from
17d3e21
to
8a531c9
Compare
Update .github/workflows/test.yml Co-authored-by: Oliver Tale-Yazdi <oliver.tale-yazdi@parity.io> add time to cmd
bkontur
force-pushed
the
bko-short-benchmarks-get_preset
branch
from
76e5409
to
1398b62
Compare
bkchr
approved these changes
Jul 22, 2024
system-parachains/collectives/collectives-polkadot/src/impls.rs
Outdated
Show resolved
Hide resolved
Co-authored-by: Bastian Köcher <git@kchr.de>
Co-authored-by: Bastian Köcher <git@kchr.de>
…enchmarks-get_preset
ggwpez
approved these changes
Jul 24, 2024
|
/merge |
|
Enabled Available commands
For more information see the documentation |
fellowship-merge-bot
bot
merged commit afe696b
into
polkadot-fellows:main
44 checks passed
| @@ -348,7 +43,9 @@ pub fn polkadot_development_config() -> Result<Box<dyn ChainSpec>, String> { | |||
| .with_name("Polakdot Development") | |||
| .with_id("polkadot-dev") | |||
| .with_chain_type(ChainType::Development) | |||
| .with_genesis_config_patch(polkadot_development_config_genesis()) | |||
| .with_genesis_config_patch( | |||
There was a problem hiding this comment.
You could use: with_genesis_config_preset_name.
This would allow to fetch the preset from the wasm blob, w/o necessity to natively compile the runtime,
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a new CI pipeline for checking and running runtime benchmarks as part of the test pipelines. This means we will now know if any changes break the benchmarks.
The pipeline is based on downloading
frame-omni-bencher(building it in-place is too expensive for every matrix run) and running it with a minimal setup:--steps 2 --repeat 1.Another part of this PR splits the default genesis setups from
chain-spec-generatorand moves them to thesp_genesis_builder::GenesisBuilder::get_presetruntime API implementation for every runtime, which is required byframe-omni-bencher.Closes: #197
Relates to: #298
Relates to: #324
Future works
When this issue is fixed, I will rewrite weight-generation.md. The new version will be significantly simplified, with instructions to simply download
frame-omni-bencher, build the runtime WASM, and run it—no other steps will be necessary.