Various backports and alignments with polkadot-sdk (which does not depend on crates.io versions)
#45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
approved these changes
Oct 18, 2023
Closed
…vs-common-good-nits
…r XcmFeeManager and paritytech/polkadot-sdk#1979) + moved tests to separate file
bkontur
changed the title
ChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminologyChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminology + other nits
…vs-common-good-nits
…vs-common-good-nits
bkontur
changed the title
ChildSystemParachainAsSuperuser from Kusama runtime + align "System" vs "common good" terminology + other nitspolkadot-sdk (which does not depend on crates.io versions)
…vs-common-good-nits
joepetrowski
approved these changes
Nov 30, 2023
andresilva
approved these changes
Nov 30, 2023
bkchr
approved these changes
Dec 7, 2023
|
/merge |
|
Enabled Available commands
For more information see the documentation |
|
cc @Bullrich |
ordian
approved these changes
Dec 8, 2023
fellowship-merge-bot
bot
merged commit d67b905
into
polkadot-fellows:main
14 checks passed
Had you rerun the bot? I mean you got added probably to the fellowship after the bot ran the last time. |
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR proposes several changes.
ChildSystemParachainAsSuperuserfeature from the Kusama runtime, as mentioned in a comment on the same PR comment link.force_default_xcm_versioninSafeCallFilterfor system parachains - based on Relaxforce_default_xcm_versionfor testnet system parachains paritytech/polkadot-sdk#2385Storageitem toPolkadotXcmpallet definition for BridgeHubs (now we cannot see storage items forpallet_xcmin polkadot.js) - based on Relaxforce_default_xcm_versionfor testnet system parachains paritytech/polkadot-sdk#2385Explanation
A significant change of PR#1406 is the redefinition of what constitutes a "system" parachain. Previously, a "system" parachain was identified with
para_id <= 1000. However, the PR#1406 changed a definition, considering a "system" parachain to havepara_id <= 1999.One consequence of this change is the reconsideration of the
ChildSystemParachainAsSuperuserfeature. This feature relies on theis_systemfunction, which, in turn, depends on the para_id of a parachain to determine "system" status. However, further examination has revealed that there is no known scenario in which a system parachain would need to call the Kusama runtime withRuntimeOrigin::root()privileges. Consequently, maintaining theChildSystemParachainAsSuperuserfeature in the Kusama runtime is deemed unnecessary.References
ChildSystemParachainAsSuperuserfrom Kusama runtime + align "System" vs "common good" terminology #32 on main.