Apply patch for a parachains inclusion pallet benchmarks

[bkontur]

Description

Addressing @ordian's comment:

Previously, the weight of enact_candidate was included in the weight of availability bitfields, but this was a bug, because the number of bitfields depends on number of validators, whereas number of enacted candidates depends on the number of cores. This was later (accidentally) fixed, but the enact_candidate weight was unaccounted for. paritytech/polkadot-sdk#5270 was supposed to fix that.

The base weight of enact_candidate still looks excessive and it was fixed in paritytech/polkadot-sdk#5526, but looks like it didn't make into the same release.

That being said, even with 1.5ms of enactment weight per candidate, this shouldn't be a blocker to scale to 200 parachains weight-wise. So I'm fine with having these excessive weights for now.

Addressing @bkontur's comment:

@ordian The next patch, stable2409-4, is planned for this week. I have backported your fix here: paritytech/polkadot-sdk#7145. Once it is released, I will re-run the benchmarks for this within another PR.

Weights diff

Kusama

--method asymptotic does not work:

subweight compare commits          --path-pattern "./relay/kusama/**/weights/**/*.rs"          --format markdown --no-color           --change added changed          --method asymptotic --ignore-errors --strip-path-prefix="relay/kusama/src/weights/"          remotes/polkadot-fellows/main          origin/bko-patch-parachains-inclusion

File	Extrinsic	Old	New	Change [%]
runtime_parachains_inclusion.rs	enact_candidate	-	-	ERROR

but --method base works:

subweight compare commits          --path-pattern "./relay/kusama/**/weights/**/*.rs"          --format markdown --no-color           --change added changed          --method base --ignore-errors --strip-path-prefix="relay/kusama/src/weights/"          remotes/polkadot-fellows/main          origin/bko-patch-parachains-inclusion

File	Extrinsic	Old	New	Change [%]
runtime_parachains_inclusion.rs	enact_candidate	2.97ms	939.10us	-68.35

Polkadot

--method asymptotic does not work:

subweight compare commits          --path-pattern "./relay/polkadot/**/weights/**/*.rs"          --format markdown --no-color           --change added changed          --method asymptotic --ignore-errors --strip-path-prefix="relay/polkadot/src/weights/"          remotes/polkadot-fellows/main          origin/bko-patch-parachains-inclusion

File	Extrinsic	Old	New	Change [%]
runtime_parachains_inclusion.rs	enact_candidate	-	-	ERROR

but --method base works:

subweight compare commits          --path-pattern "./relay/polkadot/**/weights/**/*.rs"          --format markdown --no-color           --change added changed          --method base --ignore-errors --strip-path-prefix="relay/polkadot/src/weights/"          remotes/polkadot-fellows/main          origin/bko-patch-parachains-inclusion

File	Extrinsic	Old	New	Change [%]
runtime_parachains_inclusion.rs	enact_candidate	2.92ms	974.24us	-66.60

• Does not require a CHANGELOG entry

[acatangiu]

/merge

[fellowship-merge-bot]

Enabled auto-merge in Pull Request

Available commands

• /merge: Enables auto-merge for Pull Request
• /merge cancel: Cancels auto-merge for Pull Request
• /merge help: Shows this menu

For more information see the documentation