-
Notifications
You must be signed in to change notification settings - Fork 50
Conversation
Thinking about this again, I would probably approve II Dan for you. Let's see what the others are thinking about it. |
I would support rank 2 as well. I think @koute has proven deep knowledge on our WASM execution infrastructure and has done major contributions to improve it, also outside substrate (e.g. in wasmtime). |
@andresilva @bkchr do we want to merge as it is or ask @koute to change the rank from I to II? |
Based on the WASM execution infrastructure changes alone, I'm also in favor of a II Dan here, so can take my approval as-is if others concur. (My initial rating was already for somebody that should climb up one exceptionally quickly based on the work performed in this specific environment). I also think the existing work can be turned into the basis of a strong "one published long-form semi-technical article concerning Polkadot" which should be attacked reasonably soon to conform to "This leniancy, such as it is, should exist only for the initial bootstrapping phase. By the first continuation grading, the full expectations of the member's rank should be met for approval by voters." |
Thank you all for the vote of confidence. (: I've updated the rank to 2. |
Hello @koute! Please let us know your Element handle to add you to the Fellowship channel. Thank you! |
Hey; it's |
Hi.
I'm Jan, and I have been directly contributing to Polkadot (counting from my first PR) since July 2021.
My main contributions are in the area of performance, and anything and everything WASM-related, but I also try to dabble in other areas too from time to time.
First PR
paritytech/polkadot#3519 (a memory leak fix in Polkadot)
Notable PRs
A lot of PRs improving performance:
sp_io::storage::get
paritytech/substrate#11523A lot of PRs related to the WASM executor:
wasmtime
paritytech/substrate#11189wasmtime
error reporting paritytech/substrate#11856sp-sandbox
; make sure both sandbox executors are always tested paritytech/substrate#10173This includes a new instance reuse mechanism in
wasmtime
: bytecodealliance/wasmtime#3691; while they ultimately did not use my code directly what ended up inwasmtime
was based on my work, where in this PR we switch to that new instance reuse mechanism in Substrate.Extra software and hardware metrics:
Investigative work
Leaking memory? Something's crashing randomly? Are you wasting so much CPU time that you don't need any extra heating in winter? Who ya gonna call?
Ghostbusters!Probably me!Besides direct contributions to Substrate and Polkadot I also do a lot of investigative work actually finding the issues, mostly related to memory, performance and soundness. Some examples of that:
I'm also the maintainer of Bytehound, a memory profiler for Linux, which I regularily use on Substrate/Polkadot when investigating issues.
Rank
Based on strict reading of the requirements as well as Gav's clarifications I apply for a rank of 1.Updated to rank 2. (: