Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Si V1 in contracts (w/ PortableRegistry usage) #3988

Merged
merged 27 commits into from
Oct 11, 2021
Merged

Use Si V1 in contracts (w/ PortableRegistry usage) #3988

merged 27 commits into from
Oct 11, 2021

Conversation

jacogr
Copy link
Member

@jacogr jacogr commented Sep 22, 2021

Needs use-ink/ink#845

Closes #3983
Closes #4008
Using #3987

WIP ... untested (both v0 and v1)

@jacogr jacogr added the WIP Work in Progress label Sep 22, 2021
@cmichi
Copy link

cmichi commented Sep 22, 2021

FYI: For stability reasons we just reverted substrate-contracts-node to a commit before we synced it to Substrate's metadata PR.

If you want to test the .contract file from the issue with a node that has been synced to the metadata PR you would need to use (the commit right before the revert](paritytech/substrate-contracts-node@8d91b8e).

@Robbepop
Copy link

Robbepop commented Oct 6, 2021

Hey, don't want to bother but what is the state of this cool PR? :)

@jacogr
Copy link
Member Author

jacogr commented Oct 6, 2021

I will have to get to testing at some point when I have a gap - believe the code as-is is there, but it needs full end-to-end testing against old and current (i.e. via the apps UI) and I have not had a 4hr-odd gap to go through that process as of yet.

Once done can be merged.

@jacogr jacogr removed the WIP Work in Progress label Oct 11, 2021
@jacogr jacogr merged commit d053b86 into master Oct 11, 2021
@jacogr jacogr deleted the jg-v1-si branch October 11, 2021 09:50
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

contract: "Maximum call stack size exceeded" error on recursive data Support scale-info 1.0 for contracts
4 participants