Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch rpc in url should not auto use local fork #10308

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

qiweiii
Copy link
Contributor

@qiweiii qiweiii commented Feb 29, 2024

As mentioned in #10305, this PR includes

  • Fix when user change rpc endpoint to another chain in url and load the page, it should not automatically enter local fork mode (although refreshing the page will still be in local fork mode)
  • Refactor Sidebar buttons slightly and change the order of Switch and Fork buttons, so Switch remains in the old position that users are used to.

Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested this out locally, thanks for the fix!

@TarikGul TarikGul merged commit e2db0ba into polkadot-js:master Feb 29, 2024
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants