Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add XCM encoder utility #10350

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Add XCM encoder utility #10350

merged 2 commits into from
Mar 18, 2024

Conversation

serban300
Copy link
Contributor

I am part of the bridges & XCM team

We plan to change some extrinsics from the XCM pallet to receive an encoded VersionedXcm instead of a VersionedXcm. More details here: paritytech/polkadot-sdk#1798 .

This would make it harder to call these extrinsics from PJS and in order to improve the user experience we would like to add a new utility UI for crafting encoded VersionedXcm messages.

@serban300 serban300 force-pushed the xcm branch 2 times, most recently from bb593a2 to b37c36f Compare March 12, 2024 14:17
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, its really clean. Nice work and lgtm.

The conflicts just need to be resolved.

Edit: Also tested it on your branch and it looks great.

@serban300
Copy link
Contributor Author

@TarikGul thank you for the review ! I resolved the conflicts. Could you please take another look ?

@TarikGul TarikGul merged commit ad33817 into polkadot-js:master Mar 18, 2024
5 checks passed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Mar 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants