Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xcavate-add-paseo #10889

Merged
merged 6 commits into from
Sep 10, 2024
Merged

xcavate-add-paseo #10889

merged 6 commits into from
Sep 10, 2024

Conversation

ganesh1997oli
Copy link
Contributor

No description provided.

TarikGul
TarikGul requested changes Sep 5, 2024
View reviewed changes
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ordering needs to be fixed which is what is causing the test to fail!

@ganesh1997oli
Copy link
Contributor Author

The ordering needs to be fixed which is what is causing the test to fail!

What do you mean by ordering?

@TarikGul
Copy link
Member

TarikGul commented Sep 6, 2024

The ordering needs to be fixed which is what is causing the test to fail!

What do you mean by ordering?

A before B, C, before D etc. I should have said alphabetical ordering. This is in regards to the text field

@ganesh1997oli
Copy link
Contributor Author

The ordering needs to be fixed which is what is causing the test to fail!

What do you mean by ordering?

A before B, C, before D etc. I should have said alphabetical ordering. This is in regards to the text field

I think now it should pass

@ganesh1997oli
Copy link
Contributor Author

hey @TarikGul is it ok now?

@TarikGul
Copy link
Member

TarikGul commented Sep 9, 2024

Yup looks good, we are just focusing on getting #10383 in, then we can merge this in!

@ganesh1997oli
Copy link
Contributor Author

Yup looks good, we are just focusing on getting #10383 in, then we can merge this in!

sure thank you 😊

@TarikGul TarikGul merged commit fa05f14 into polkadot-js:master Sep 10, 2024
5 checks passed
@ganesh1997oli
Copy link
Contributor Author

hey @TarikGul our logo doesn't looks good, can we open new PR for that?

@TarikGul
Copy link
Member

@ganesh1997oli Ofcourse, feel free!

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@TarikGul TarikGul TarikGul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ganesh1997oli @TarikGul @polkadot-js-bot