Fix: updated parsing for brokerConfig and brokerSalesInfo #10926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TarikGul
requested changes
Sep 18, 2024
| @@ -11,17 +11,17 @@ import { createNamedHook, useApi, useCall } from '@polkadot/react-hooks'; | |||
| import { stringToBN } from './utils/dataProcessing.js'; | |||
|
|
|||
| function parseConfig (config: PalletBrokerConfigRecord): SimplifiedPalletBrokerConfigRecord { | |||
| const c = config.toJSON(); | |||
| const c = config?.toJSON(); | |||
There was a problem hiding this comment.
This should actually be like this:
function parseConfig (config: PalletBrokerConfigRecord): SimplifiedPalletBrokerConfigRecord {
return {
advanceNotice: config.advanceNotice.toNumber(),
contributionTimeout: config.contributionTimeout.toNumber(),
idealBulkProportion: stringToBN(config.idealBulkProportion?.toString()),
interludeLength: config.interludeLength.toNumber(),
leadinLength: config.leadinLength.toNumber(),
limitCoresOffered: config.limitCoresOffered.isSome ? config.limitCoresOffered.unwrap().toNumber() : 0,
regionLength: config.regionLength.toNumber(),
renewalBump: stringToBN(config.renewalBump?.toString())
};
}There was a problem hiding this comment.
And if config can be undefined, then the param type needs to be updated.
| record: PalletBrokerSaleInfoRecord | ||
| ): SimplifiedPalletBrokerSaleInfoRecord { | ||
| const rec = record.toJSON(); | ||
| function parsePalletBrokerSaleInfoRecord (record: PalletBrokerSaleInfoRecord): SimplifiedPalletBrokerSaleInfoRecord { |
TarikGul
reviewed
Sep 18, 2024
| regionBegin: record.regionBegin.toNumber(), | ||
| regionEnd: record.regionEnd.toNumber(), | ||
| saleStart: record.saleStart.toNumber(), | ||
| selloutPrice: record.selloutPrice.isSome ? record.selloutPrice.unwrap() : 0 |
There was a problem hiding this comment.
Small nit, but I think you can set the 0 to new BN(0) if you want the values to be inline. That being said its a small nit.
TarikGul
approved these changes
Sep 18, 2024
juangirini
pushed a commit
to ideal-lab5/polkadot-js-apps
that referenced
this pull request
Sep 19, 2024
…s#10926) * updated parsing for brokerConfig and brokerSalesInfo * renamed file * updated parsing for brokerConfig and brokerSalesInfo * better type conversion for BN * BN type change * lint
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.