Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attestation to claims #2734

Merged
merged 79 commits into from
May 26, 2020
Merged

Add attestation to claims #2734

merged 79 commits into from
May 26, 2020

Conversation

Tbaut
Copy link
Contributor

@Tbaut Tbaut commented May 13, 2020 •
edited
Loading

Let DOT token holders claim their token by:

  • signing a statement and a claim with their Ethereum key if their tokens are not pre-claimed
  • signing a statement only if the tokens where pre-claimed before launch

@Tbaut Tbaut added the WIP Work in Progress label May 13, 2020
@amaury1093 amaury1093 mentioned this pull request May 13, 2020
Closed
@Tbaut
Add ETH address field for non preclaimed addresses (#2746)
94d496c 
* Eth field

* fix

* remove stray logs
@amaury1093 amaury1093 removed the WIP Work in Progress label May 25, 2020
@amaury1093 amaury1093 marked this pull request as ready for review May 25, 2020 09:13
jacogr
jacogr reviewed May 25, 2020
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment, let's just bring down the number of instances down from 3 to 2. Assuming it works and doesn't break Kusama (we still have people claiming, i.e. speaking to somebody right atm), it is fine.

packages/page-claims/src/statements/polkadot/regular.tsx Outdated Show resolved Hide resolved
packages/page-claims/src/util.ts Show resolved Hide resolved
@Tbaut Tbaut requested review from amaury1093 and jacogr May 25, 2020 18:10
jacogr
jacogr approved these changes May 26, 2020
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you very much for this.

lgtm, merge when happy.

@lsaether lsaether mentioned this pull request May 26, 2020
Merged
@amaury1093 amaury1093 merged commit 0091fc6 into master May 26, 2020
@amaury1093 amaury1093 deleted the tbaut-attest branch May 26, 2020 09:49
@amaury1093
Copy link
Contributor

Thanks everyone who participated in this PR 🎉

This was referenced May 27, 2020
Merged
Closed
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lsaether lsaether lsaether left review comments

@jacogr jacogr jacogr approved these changes

@amaury1093 amaury1093 Awaiting requested review from amaury1093

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Tbaut @Swader @jacogr @amaury1093 @polkadot-js-bot @lsaether