Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ethereum icons based on URL #9694

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

wirednkod
Copy link
Member

Fixes #9632

@wirednkod wirednkod requested a review from jacogr July 13, 2023 16:00
@wirednkod
Copy link
Member Author

wirednkod commented Jul 13, 2023

There is (probably) a better way of doing that (reading the parameters instead of just mapping a string) and could help for customizing the icons based on that new param.. @jacogr let me know if you prefer to extend it that way instead of a single param match

Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it doesn't hurt having this.

We now have multiple ways -

  • as part of the hard-coded list
  • as part of the chain properties (which is probably the preferred route)
  • this

@jacogr jacogr merged commit 48dafee into master Dec 12, 2023
@jacogr jacogr deleted the nik-select-ethereum-from-url branch December 12, 2023 06:27
@JoshOrndorff
Copy link
Contributor

as part of the chain properties (which is probably the preferred route)

I think I missed that one. Sorry for the DQ, but is the property name and value?

@jacogr
Copy link
Member

jacogr commented Dec 12, 2023

This PR will add support here - #9667 (links through to the API changes, like this PR, also gracefully contributed - so certainly not widespread yet. This should be the last piece of the puzzle after polkadot-js/api#5761)

@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setting to manually tell Apps to use ethereum-style accounts and signatures
4 participants