Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Dora Factory #9739

Closed
wants to merge 5 commits into from
Closed

Remove Dora Factory #9739

wants to merge 5 commits into from

Conversation

Leemo94
Copy link
Contributor

@Leemo94 Leemo94 commented Jul 28, 2023

Leemo94 added 4 commits July 28, 2023 11:53
Removed Dora Factory
Removed Dora Factory
Removed Dora Factory
Remove Dora Factory
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you. Just needs some adjustment to the unused imports (GH is now quite clever showing those inline)

Remove Dora Factory
@@ -182,19 +182,6 @@ export const prodParasKusama: Omit<EndpointOption, 'teleport'>[] = [
logo: nodesIpciSVG
}
},
{
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While still registered on-chain, see

image

The complete removal is a bit heavy-handed. All good removing the RPC endpoints, but the link from id -> name should stay in-tact.

@jacogr
Copy link
Member

jacogr commented Aug 1, 2023

Ooops, sorry for this - seems I did catch the endpoints as part of #9749

So the RPC is now disabled.

Sorry for stepping on your toes here, just have been a bit behind with the issues logged by CI, so I ended up with a whole bunch to disable when I got around to it...

@jacogr jacogr closed this Aug 1, 2023
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants