Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typeBundle for Cere Network #9789

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Add typeBundle for Cere Network #9789

merged 2 commits into from
Aug 17, 2023

Conversation

shamilkhan
Copy link
Contributor

No description provided.

jacogr
jacogr requested changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This specific file, typesBundle.ts (as per the comment on line 4) is auto-generated, so any merge would just lose the changes completely.

It is built from the config as set in apps-config/api/spec - unless there are changes made there, trying to change the generated file is futile.

@shamilkhan
Copy link
Contributor Author

This specific file, typesBundle.ts (as per the comment on line 4) is auto-generated, so any merge would just lose the changes completely.

It is built from the config as set in apps-config/api/spec - unless there are changes made there, trying to change the generated file is futile.

Thanks! Let me fix it.

@shamilkhan shamilkhan requested a review from jacogr August 17, 2023 13:26
@shamilkhan
Copy link
Contributor Author

This specific file, typesBundle.ts (as per the comment on line 4) is auto-generated, so any merge would just lose the changes completely.

It is built from the config as set in apps-config/api/spec - unless there are changes made there, trying to change the generated file is futile.

Could you check again, please?

jacogr
jacogr approved these changes Aug 17, 2023
View reviewed changes
Copy link
Member

@jacogr jacogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems spot-on.

@jacogr jacogr merged commit 2e5b0a2 into polkadot-js:master Aug 17, 2023
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 19, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jacogr jacogr jacogr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shamilkhan @polkadot-js-bot @jacogr