fix(map): Add binary option to several functions #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pollination/ladybug_comfort/map.py
Outdated
| plain_text = Inputs.str( | ||
| description='Flag to note whether the output should be formatted as a ' | ||
| 'plain text CSV or whether it should be formatted as a binary numpy ' | ||
| 'array.', default='plain-text', |
There was a problem hiding this comment.
I think we should add a sentence to indicate why the user should pick one over the other. Not everyone would know the difference between the two, and the right choice for their case.
There was a problem hiding this comment.
@mostaphaRoudsari, I expanded the description of the input.
pollination/ladybug_comfort/map.py
Outdated
| @@ -291,14 +291,24 @@ class UtciMap(Function): | |||
| 'will be for the entire result_sql run period.', default='' | |||
| ) | |||
|
|
|||
| plain_text = Inputs.str( | |||
There was a problem hiding this comment.
Maybe we should call this output_format since that's a better description of what this pollination function is.
There was a problem hiding this comment.
I changed the name of the function input.
|
🎉 This issue has been resolved in version 0.5.4 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge ladybug-tools/ladybug-comfort#372 first and wait for new release.