Skip to content

Commit

Permalink
fix(prepare-dynamic): provide optional output parameter
Browse files Browse the repository at this point in the history
I'm not sure if this is a limitation of Argo or something that we are not translating over but what is happening is that the function has an optional parameter that is not set to optional when translated to Argo.

```yaml
      outputs:
        parameters:
          - name: five-phase-info
            valueFrom:
              path: /workspace/five_phase.json
```
  • Loading branch information
mostaphaRoudsari committed Jul 1, 2022
1 parent 461fe9e commit 8707693
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 2 deletions.
2 changes: 1 addition & 1 deletion pollination/three_phase/entry.py
Original file line number Diff line number Diff line change
Expand Up @@ -170,7 +170,7 @@ def create_direct_sky(
@task(template=PrepareMultiphase, needs=[create_rad_folder, generate_sunpath])
def prepare_dynamic(
self, model=create_rad_folder._outputs.model_folder,
sunpath=generate_sunpath._outputs.sunpath, phase=3, cpu_count=cpu_count,
sunpath=generate_sunpath._outputs.sunpath, phase=5, cpu_count=cpu_count,
cpus_per_grid=3, min_sensor_count=min_sensor_count, static='include'
):
return [
Expand Down
1 change: 0 additions & 1 deletion pollination/three_phase/three_phase/preparation.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
from pollination_dsl.dag import Inputs, DAG, task, Outputs
from pollination_dsl.dag.inputs import ItemType
from dataclasses import dataclass

from pollination.honeybee_radiance.multiphase import DaylightMatrixGrouping, \
Expand Down

0 comments on commit 8707693

Please sign in to comment.