Skip to content

Commit

Permalink
address review
Browse files Browse the repository at this point in the history
  • Loading branch information
FreeApophis committed Aug 30, 2023
1 parent c41638e commit e4edc51
Show file tree
Hide file tree
Showing 5 changed files with 15 additions and 16 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -74,9 +74,9 @@ public async Task SlidingWindowReturnsASequenceOfConsecutiveWindowsAsync()

await AsyncAssert.Collection(
source.SlidingWindow(width),
window => { Assert.Equal(Enumerable.Range(0, width), window); },
window => { Assert.Equal(Enumerable.Range(1, width), window); },
window => { Assert.Equal(Enumerable.Range(2, width), window); });
window => Assert.Equal(Enumerable.Range(0, width), window),
window => Assert.Equal(Enumerable.Range(1, width), window),
window => Assert.Equal(Enumerable.Range(2, width), window));
}

[Fact]
Expand Down
3 changes: 1 addition & 2 deletions Funcky.Async/Funcky.Async.csproj
Original file line number Diff line number Diff line change
Expand Up @@ -14,8 +14,7 @@
<EnableNETAnalyzers>true</EnableNETAnalyzers>
<AnalysisModeReliability>All</AnalysisModeReliability>
<EnablePackageValidation>true</EnablePackageValidation>
<NoWarn>$(NoWarn);RS0026</NoWarn>
<!-- RS0026: Do not add multiple overloads with optional parameters -->
<NoWarn>$(NoWarn);RS0026</NoWarn><!-- RS0026: Do not add multiple overloads with optional parameters -->
</PropertyGroup>
<PropertyGroup>
<RootNamespace>Funcky</RootNamespace>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,8 +70,8 @@ public void SlidingWindowReturnsASequenceOfConsecutiveWindows()

Assert.Collection(
source.SlidingWindow(width),
window => { Assert.Equal(Enumerable.Range(0, width), window); },
window => { Assert.Equal(Enumerable.Range(1, width), window); },
window => { Assert.Equal(Enumerable.Range(2, width), window); });
window => Assert.Equal(Enumerable.Range(0, width), window),
window => Assert.Equal(Enumerable.Range(1, width), window),
window => Assert.Equal(Enumerable.Range(2, width), window));
}
}
8 changes: 4 additions & 4 deletions Funcky.Test/Extensions/StringExtensions/ChunkOnStringTest.cs
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ public class ChunkOnStringTest
{
[Property]
public Property ChunkingAnEmptyStringWillAlwaysYieldAndEmptySequence(PositiveInt width)
=> string.Empty
.Chunk(width.Get)
.None()
.ToProperty();
=> string.Empty
.Chunk(width.Get)
.None()
.ToProperty();

[Fact]
public void GivenAnSingleElementListWeGetEnumerableWithOneElement()
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,10 @@ public void SlidingWindowReturnsAListOfOverlappingPartialStrings()

Assert.Collection(
source.SlidingWindow(width),
window => { Assert.Equal("epsi", window); },
window => { Assert.Equal("psil", window); },
window => { Assert.Equal("silo", window); },
window => { Assert.Equal("ilon", window); });
window => Assert.Equal("epsi", window),
window => Assert.Equal("psil", window),
window => Assert.Equal("silo", window),
window => Assert.Equal("ilon", window));
}

[Fact]
Expand Down

0 comments on commit e4edc51

Please sign in to comment.