Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Isuzu ISK filter catalog entries #54

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

kmdouglass
Copy link
Contributor

This bug appeared in commit 682c381

@kmdouglass kmdouglass changed the title Fix Isuzu ISK fiber catalog entries Fix Isuzu ISK filter catalog entries Dec 16, 2024
@kmdouglass
Copy link
Contributor Author

kmdouglass commented Dec 16, 2024

By the way, I'm finding these sorts of errors when I attempt to parse the entire database into a strongly typed representation that I wrote in Rust to convert it into a flat key-value store. The conversion utterly fails unless the entries match the data model exactly.

@polyanskiy polyanskiy merged commit 5992333 into polyanskiy:master Dec 17, 2024
1 check passed
@polyanskiy
Copy link
Owner

Hi,
You mentioned converting the database into a different format. I’m wondering if you have any thoughts on potential improvements to the database structure. Or does it not really matter as long as an automatic conversion can be tailored to user needs?

@kmdouglass kmdouglass deleted the fix-isuzu-catalog-entries branch December 17, 2024 06:18
@kmdouglass
Copy link
Contributor Author

kmdouglass commented Dec 17, 2024

I’m wondering if you have any thoughts on potential improvements to the database structure.

I think that the database is already in a pretty good format. The schema I created to parse the catalog is pretty simple:

The only time I encounter problems is when subtle errors like this one violate the schema. Reading the entire database into memory, converting it to my needed representation, and then dumping this back to disk takes only 2 or 3 seconds on my laptop.

The reason I'm doing this is that I am working on a ray tracer for optical systems design that lives entirely in the browser. There is no backend. My plan is to serve the single file with my application's artifacts, download it when the site is first accessed, and then load it into the browser's local IndexedDB. IndexedDB is a key/value store, which is why I'm flattening the entire database into what is essentially a dict.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants