Ignore io.EOF comparison for (*bufio.Reader).ReadLine #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Although the documentation for (*bufio.Reader).ReadLine do not mention io.EOF explicitly, this function can also return it -- the implementation [1] user ReadSlice() which is documented to return io.EOF. [1] https://golang.org/src/bufio/bufio.go?s=10168:10235#L378 Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
|
Thanks! |
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Jun 29, 2023
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
lifubang
pushed a commit
to kolyshkin/runc
that referenced
this pull request
Jul 16, 2023
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Aug 9, 2023
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 98317c1) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
kolyshkin
added a commit
to kolyshkin/runc
that referenced
this pull request
Aug 9, 2023
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 98317c1) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
thaJeztah
pushed a commit
to thaJeztah/sys
that referenced
this pull request
Sep 16, 2023
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
tianon
pushed a commit
to tianon/moby-sys
that referenced
this pull request
Sep 16, 2023
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
dims
pushed a commit
to dims/libcontainer
that referenced
this pull request
Oct 19, 2024
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
dims
pushed a commit
to dims/libcontainer
that referenced
this pull request
Oct 19, 2024
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit 98317c1) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
dims
pushed a commit
to dims/libcontainer
that referenced
this pull request
Oct 19, 2024
The exception was fixed by polyfloyd/go-errorlint#12 which eventually made its way into golangci-lint. Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com> (cherry picked from commit eec8b08910c15b506043c1057ca991394bdb04fd) Signed-off-by: Kir Kolyshkin <kolyshkin@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the documentation for (*bufio.Reader).ReadLine
do not mention io.EOF explicitly, this function can also
return it -- the implementation [1] user ReadSlice() which
is documented to return io.EOF.
[1] https://golang.org/src/bufio/bufio.go?s=10168:10235#L378
Found in opencontainers/runc@02c23c4
Signed-off-by: Kir Kolyshkin kolyshkin@gmail.com