sort order doesn't work

[chadkouse]

I can't tell if it's something new in 0.90 or if it's just a documentation error but they show using both "order" and "sort_order" to control the order of the sort. Turns out at least in pre 0.90 "sort_order" doesn't work, only "order" will work

[polyfractal]

Hmm, it's either a documentation error or only applies to the new nested, multi-valued docs. In the Java source they only look at "order":

[...]
else if ("order".equals(innerJsonName)) {
  if ("asc".equals(parser.text())) {
    reverse = SCORE_FIELD_NAME.equals(fieldName);
  } else if ("desc".equals(parser.text())) {
    reverse = !SCORE_FIELD_NAME.equals(fieldName);
  }
}
[...]

If you add a pull request I'll merge/tag/push. I'm following up with the ES devs to see if this is an error or just specific to multi-value.

Thanks, and sorry for letting this slip through. My unit tests only check for successful queries...I need to spend some time working up better test environments so query results themselves can be tested (e.g. make sure things are sorting correctly).

[chadkouse]

i have a change ready.. just about to submit the PR

Chad Kouse

On Tuesday, March 12, 2013 at 2:57 PM, Zachary Tong wrote:

Hmm, it's either a documentation error or only applies to the new nested, multi-valued docs. In the Java source (https://github.com/elasticsearch/elasticsearch/blob/master/src/main/java/org/elasticsearch/search/sort/SortParseElement.java#L137) they only look at "order":
[...] else if ("order".equals(innerJsonName)) { if ("asc".equals(parser.text())) { reverse = SCORE_FIELD_NAME.equals(fieldName); } else if ("desc".equals(parser.text())) { reverse = !SCORE_FIELD_NAME.equals(fieldName); } } [...]

If you add a pull request I'll merge/tag/push. I'm following up with the ES devs to see if this is an error or just specific to multi-value.
Thanks, and sorry for letting this slip through. My unit tests only check for successful queries...I need to spend some time working up better test environments so query results themselves can be tested (e.g. make sure things are sorting correctly).

—
Reply to this email directly or view it on GitHub (#14 (comment)).

[polyfractal]

Looks like it was a documentation error: https://github.com/elasticsearch/elasticsearch.github.com/commit/37666db946b9c2b4ad496449110100d223aa236f