Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serialize boolean parameters as lowercase strings in url #313

Merged
merged 5 commits into from
Oct 5, 2022

Conversation

suremarc
Copy link
Contributor

@suremarc suremarc commented Oct 5, 2022

A customer reported the following issue: using boolean query parameters serializes them as True or False instead of true and false. See here.

This PR change boolean query parameters to be serialized as lowercase strings, which is what our APIs expect.

Copy link
Contributor

@clickingbuttons clickingbuttons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty!

@suremarc
Copy link
Contributor Author

suremarc commented Oct 5, 2022

@clickingbuttons all the tests are failing... :(

@suremarc suremarc enabled auto-merge (squash) October 5, 2022 19:55
@suremarc suremarc merged commit 0a4aaa1 into master Oct 5, 2022
@suremarc suremarc deleted the serialize-bool branch October 5, 2022 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants