Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update readme #365

Merged
merged 4 commits into from
Jan 19, 2023
Merged

Update readme #365

merged 4 commits into from
Jan 19, 2023

Conversation

antdjohns
Copy link
Contributor

@antdjohns antdjohns commented Jan 19, 2023

Addressing ticket

Updating README to include examples and Quickstart guide so users don't need to navigate to multiple pages.

  • Added Examples for RESTClient
  • Added Example for WebSocketClient
  • Added Example for Launchpad.

This update is based on the README used in client-go with more brevity of steps.

@antdjohns antdjohns requested review from qrpike and removed request for qrpike January 19, 2023 21:40
@antdjohns antdjohns enabled auto-merge (squash) January 19, 2023 21:40
Copy link
Collaborator

@jbonzo jbonzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great.
@qrpike thoughts?

@antdjohns antdjohns merged commit 3c1570c into master Jan 19, 2023
@antdjohns antdjohns deleted the update-readme branch January 19, 2023 22:06
@qrpike
Copy link
Contributor

qrpike commented Jan 19, 2023

Looks great. @qrpike thoughts?

Very nice! 👍 @antdjohns I would put Launchpad last since it will have the smallest size audience compared to the other sections.

@antdjohns
Copy link
Contributor Author

Looks great. @qrpike thoughts?

Very nice! 👍 @antdjohns I would put Launchpad last since it will have the smallest size audience compared to the other sections.

too easy. ill push up a pr now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants