Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stocks demo scripts #377

Merged
merged 9 commits into from
Feb 13, 2023
Merged

Conversation

justinpolygon
Copy link
Contributor

Added demos for each stocks API endpoint. Some of the demos show off csv export, pretty printing content, looping through trades to count cash, etc. The intent is to give new users working examples. There are also links to the API docs and client library API docs.

Copy link

@mmoghaddam385 mmoghaddam385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lots of great examples and documentation here! I just left a couple small questions

examples/rest/stocks-mrk-aggregates_bars.py Outdated Show resolved Hide resolved
examples/rest/stocks-ws.py Outdated Show resolved Hide resolved
Copy link

@timetraveler328 timetraveler328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@justinpolygon justinpolygon changed the title added demo scripts added stocks demo scripts Feb 10, 2023
@justinpolygon justinpolygon changed the title added stocks demo scripts Add stocks demo scripts Feb 10, 2023
examples/rest/stocks-mrk-aggregates_bars.py Outdated Show resolved Hide resolved
examples/rest/stocks-ws.py Outdated Show resolved Hide resolved
@justinpolygon
Copy link
Contributor Author

justinpolygon commented Feb 13, 2023

Mind checking one more time and make sure things make senes @mmoghaddam385. Typical new guy here, submits a massive PR, and then goes through lots of revisions :). Sorry about that.

Copy link

@mmoghaddam385 mmoghaddam385 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@justinpolygon justinpolygon merged commit 4d8ab1c into polygon-io:master Feb 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants