Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two bugs #382 and #388 that have reported query filter extensions ("lt", "lte", "gt", "gte", "any_of") are not working as expected. Thanks to the debug work of
jakekdodd
it was easy to track down the source of the bug.Examples of the malformed params being passed to the API before the fix:
expiration.date_gte
strike.price_gte
Examples of what these should look like:
expiration_date.gte
strike_price.gte
Example 1 - code to test (these should both get you the same result):
Example 2 - code to test (these should both get you the same result):
Note: I didn't end up using the suggested code from the bug report, since removesuffix requires python 3.9, and we say the client library should work with 3.8. So, didn't want to break a bunch of existing code.
Credits: Thanks for the great debug work @jakekdodd.