Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle JSON decoding errors in _get and _paginate_iter #500

Merged
merged 1 commit into from
Aug 20, 2023

Conversation

justinpolygon
Copy link
Contributor

Wrapped the JSON decoding process in a try-except to catch ValueError. In case of a decoding error, a log message is printed, and the function returns an empty list. Fixes #499.

@justinpolygon justinpolygon merged commit 1959639 into master Aug 20, 2023
@justinpolygon justinpolygon deleted the jw-verify-json-response branch August 20, 2023 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BaseClient.decode() throws an exception when /v3/reference/dividends returns an empty page
2 participants