Skip to content

Commit

Permalink
Add new error message for unrecognized cross domain messages
Browse files Browse the repository at this point in the history
  • Loading branch information
natebeauregard committed Sep 18, 2024
1 parent c11a540 commit 23f31e0
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions x/rollup/keeper/deposits.go
Original file line number Diff line number Diff line change
Expand Up @@ -122,9 +122,10 @@ func (k *Keeper) processL1UserDepositTxs(
// Do not return an error if the cross domain message can't be parsed or executed to keep the
// state transitions from the other deposit txs
if err != nil {
// TODO: should this log be a warning or error?
ctx.Logger().Warn("Failed to parse or execute cross domain message", "err", err)
} else if erc20mintEvent != nil {
} else if erc20mintEvent == nil {
ctx.Logger().Warn("Cross domain message not recognized", "txData", tx.Data())
} else {
mintEvents = append(mintEvents, *erc20mintEvent)
}
}
Expand Down

0 comments on commit 23f31e0

Please sign in to comment.