Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arithmetic overflow on view counter #17

Closed
6 tasks done
Teskann opened this issue Feb 4, 2024 · 1 comment
Closed
6 tasks done

Arithmetic overflow on view counter #17

Teskann opened this issue Feb 4, 2024 · 1 comment
Labels
🪲 bug Something isn't working

Comments

@Teskann
Copy link

Teskann commented Feb 4, 2024

Checklist

  • I am able to reproduce the bug with the latest version given here: CLICK THIS LINK.
  • I made sure that there are no existing issues - open or closed - which I could contribute my information to.
  • I have read the FAQ and my problem isn't listed.
  • I have taken the time to fill in all the required details. I understand that the bug report will be dismissed otherwise.
  • This issue contains only one bug.
  • I have read and understood the contribution guidelines.

Affected version

0.26.1_r2

Steps to reproduce the bug

Open any video with more than 2.15B views, such as this one

Expected behavior

The number of likes is displayed as expected (in the case of the video above about 3.660B views)

Actual behavior

You might see a negative value for the views, in the case of the video above, -634M

Screenshots/Screen recordings

No response

Logs

No response

Affected Android/Custom ROM version

No response

Affected device model

No response

Additional information

New Pipe 0.26.1 is not affected by this bug, this is why I report it here.

Probably using a 64 bits integer would be more suitable for the views counter.

@Teskann Teskann added the 🪲 bug Something isn't working label Feb 4, 2024
@mikooomich
Copy link
Contributor

Yep, can reproduce. This however, is fixed in NewPipe's current dev branch (somewhere).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants