-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rust core use NDK >= r23 #1086
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine, just the usual questions to understand it a bit better.
GH action fails mostly due to GH env still using obsolete ndk-bundle. However GH is about to remove it, probably in favour of normal android NDK -> actions/runner-images#5879. Will postpone this PR until GH makes all the changes on the env, which will happen on Monday 24th. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. The .fbs file was simply left over, right?
Right. |
So this is workaround to allow building core with any NDK version >= r23. This is a little bit of magic I didn't want to do initially, but it seems that is quite safe(many projects also adopted this kind of solution).
The root cause of the issue is that newer NDK versions use
-lunwind
instead of-libgcc
, while rust building system seems to be using still the version with-libgcc
What changed:
-lunwind
as-libgcc