Add Scala 3.2.0 #107
Merged
Add Scala 3.2.0 #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keynmol
commented
Sep 6, 2022
| @@ -89,7 +89,8 @@ val plugin = project.settings( | |||
| Compile / unmanagedSourceDirectories ++= { | |||
| val extraDirectoriesWithPredicates = Map[String, String => Boolean]( | |||
| ("scala-3.0.x", (_.startsWith("3.0"))), | |||
| ("scala-3.1.0+", (v => v.startsWith("3") && !v.startsWith("3.0"))) | |||
There was a problem hiding this comment.
my motivation was that it's impossible for both to be true :P
There was a problem hiding this comment.
As far as I can see this would've matched on any 3.x version where x isn't 0
There was a problem hiding this comment.
Oh right, I can't read - I was commenting on the broken version I myself have authored prior to this..
kubukoz
approved these changes
Sep 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this works
I went ahead and made the unmanaged sources logic dumber - perhaps it will be enough for now?