Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tcp: add extended tcp support #186

Merged
merged 1 commit into from
Dec 27, 2022
Merged

tcp: add extended tcp support #186

merged 1 commit into from
Dec 27, 2022

Conversation

calebdoxsey
Copy link
Contributor

Summary

Add extended TCP support so that in addition to:

pomerium-cli tcp redis.example.com:6379

You can also use:

pomerium-cli tcp tcp+https://proxy.example.com/redis.example.com:6379

The existing pomerium-url option also still works.

Related issues

Fixes https://github.com/pomerium/internal/issues/1201

Checklist

  • reference any related issues
  • updated unit tests
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey added the enhancement New feature or request label Dec 27, 2022
@calebdoxsey calebdoxsey requested a review from a team as a code owner December 27, 2022 21:38
@calebdoxsey calebdoxsey requested a review from wasaga December 27, 2022 21:38
@calebdoxsey calebdoxsey merged commit 7e0f697 into main Dec 27, 2022
@calebdoxsey calebdoxsey deleted the cdoxsey/extended-tcp branch December 27, 2022 22:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@desimone desimone desimone approved these changes

@wasaga wasaga Awaiting requested review from wasaga wasaga is a code owner automatically assigned from pomerium/dev-backend

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@calebdoxsey @desimone