Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add load connections form #433

Merged
merged 7 commits into from
Jan 24, 2025
Merged

add load connections form #433

merged 7 commits into from
Jan 24, 2025

Conversation

calebdoxsey
Copy link
Collaborator

Summary

This adds a new form to load connections from a Pomerium URL using the new routes discovery portal. TCP and UDP connections will be created automatically.

I attempted to make it preserve any manually edited settings that aren't directly set by the load form (like the listener address).

The Load Form has an advanced section similar to the regular form. Those connection options will be used for each of the created connections. (For example to disable TLS)

The inputs on this form are saved into local storage so the user can reload their connections quickly.

Other changes:

  • the API protobuf was regenerated based on changes from routes: add routes list command cli#487
  • I noticed while testing that loading the routes was a little racy, so I added some async helpers so we can wait for the save to complete before reloading all the routes again
  • The "New Connection" button was changed into a pop-over. This was mostly copied from the zero ui.
  • I pulled out the TagSelector into a component
  • I added some spacing between the header and forms on some of the pages. The buttons seemed to close to the border of the form.

Related issues

  • Fixes ENG-1879

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@calebdoxsey calebdoxsey requested review from a team as code owners January 24, 2025 17:58
@calebdoxsey calebdoxsey requested review from nhayfield and kralicky and removed request for a team January 24, 2025 17:58
Copy link
Collaborator

@nhayfield nhayfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is most of this prettier updates?

Copy link
Collaborator

@nhayfield nhayfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reviewing individual commits this makes more sense.

@calebdoxsey calebdoxsey merged commit 9191c58 into main Jan 24, 2025
5 checks passed
@calebdoxsey calebdoxsey deleted the cdoxsey/load-form branch January 24, 2025 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants