feat: add ExternalIPs for proxy Service #306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
rguichard
force-pushed
the
proxy-svc-externalips
branch
from
f3ef8e4 to
0fdb57b
Compare
calebdoxsey
previously approved these changes
May 23, 2022
|
@rguichard thanks! Looks like it needs a version bump for the tests to pass. |
auto-merge was automatically disabled
May 24, 2022 07:22
Head branch was pushed to by a user without write access
rguichard
force-pushed
the
proxy-svc-externalips
branch
2 times, most recently
from
c335b82 to
aeca71e
Compare
|
I bump Chart.yaml to |
|
@calebdoxsey could you re-approve this PR to trigger CI tests ? |
|
@rguichard tests look good, just need to resolve the merge conflict now. Thanks! |
rguichard
force-pushed
the
proxy-svc-externalips
branch
from
aeca71e to
87bcc5e
Compare
|
@desimone done ! |
desimone
approved these changes
Jun 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Allow Proxy Service to use ExternalPs. Usefull when you want to bind your Ingress Controller to a specific public IP.
Checklist: