Fixes the annotations in deployments and services #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
victornoel
force-pushed
the
fix-annotations
branch
from
633e725 to
cf80236
Compare
Signed-off-by: Victor Noel <victor.noel@brennus-analytics.com>
victornoel
force-pushed
the
fix-annotations
branch
from
cf80236 to
2907aba
Compare
desimone
approved these changes
Jan 17, 2020
I think that's okay and/or helm ignores it, but no harm in the change to make it explicit. |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Sorry I missed it during the review of the previous PR on this, but there was two bugs with it:
annotationswas at the wrong level for servicesannotationswasn't set in the values, a field without any value was generated which I think is illegal.