-
Notifications
You must be signed in to change notification settings - Fork 9
Allow controller to watch multiple ingress classes #40
Allow controller to watch multiple ingress classes #40
Conversation
Codecov Report
@@ Coverage Diff @@
## master #40 +/- ##
==========================================
- Coverage 72.72% 72.63% -0.10%
==========================================
Files 7 7
Lines 396 402 +6
==========================================
+ Hits 288 292 +4
- Misses 77 79 +2
Partials 31 31
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rocketspacer Thank you for the PR! LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much for the PR. Two comments - one minor and one maybe a little larger in scope. I don't think either needs much in the way of test changes though. Thanks for the thorough attention on the testing front!
05fd4a3
to
ce04236
Compare
@travisgroth I just rebased and updated the code according to our conversation. Please check again 🙏 Sorry for the long delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
@travisgroth when do you plan to release this? |
@rocketspacer Actually, today! |
Usage: