Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Allow controller to watch multiple ingress classes #40

Merged
merged 8 commits into from
Dec 16, 2020

Conversation

rkt2spc
Copy link
Contributor

@rkt2spc rkt2spc commented Mar 2, 2020

Usage:

# Deployments
...
spec:
  containers:
  ...
  - name: pomerium
    image: pomerium/pomerium-operator:v0.0.1-rc1
    args:
    ...
    - --ingress-class='/(nginx|pomerium)/'
    - --service-class='/(pomerium|nginx-.+)/'
    ...
  ...

@codecov
Copy link

codecov bot commented Mar 2, 2020

Codecov Report

Merging #40 (a1a5847) into master (7618bea) will decrease coverage by 0.09%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #40      +/-   ##
==========================================
- Coverage   72.72%   72.63%   -0.10%     
==========================================
  Files           7        7              
  Lines         396      402       +6     
==========================================
+ Hits          288      292       +4     
- Misses         77       79       +2     
  Partials       31       31              
Impacted Files Coverage Δ
internal/controller/reconciler.go 79.62% <100.00%> (+2.54%) ⬆️
internal/configmanager/configmanager.go 83.33% <0.00%> (-2.39%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7618bea...a1a5847. Read the comment docs.

Copy link
Collaborator

@desimone desimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rocketspacer Thank you for the PR! LGTM

Copy link
Contributor

@travisgroth travisgroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for the PR. Two comments - one minor and one maybe a little larger in scope. I don't think either needs much in the way of test changes though. Thanks for the thorough attention on the testing front!

internal/controller/reconciler.go Outdated Show resolved Hide resolved
internal/controller/reconciler.go Outdated Show resolved Hide resolved
@CLAassistant
Copy link

CLA assistant check
All committers have signed the CLA.

@rkt2spc rkt2spc force-pushed the watch-controller-class-pattern branch from 05fd4a3 to ce04236 Compare November 24, 2020 10:42
@rkt2spc
Copy link
Contributor Author

rkt2spc commented Nov 24, 2020

@travisgroth I just rebased and updated the code according to our conversation. Please check again 🙏 Sorry for the long delay.

@travisgroth travisgroth added this to the 2020Q4 - Sprint 3 milestone Dec 1, 2020
Copy link
Contributor

@travisgroth travisgroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@travisgroth travisgroth merged commit 83a7a10 into pomerium:master Dec 16, 2020
@rkt2spc
Copy link
Contributor Author

rkt2spc commented Jan 25, 2021

@travisgroth when do you plan to release this?

@travisgroth
Copy link
Contributor

@rocketspacer Actually, today!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants