Skip to content
This repository has been archived by the owner on Sep 20, 2022. It is now read-only.

Prevent spurious configuration saves #56

Merged
merged 2 commits into from
May 11, 2020

Conversation

travisgroth
Copy link
Contributor

Make sure policy always has a consistent order to prevent spurious saves to API server.

@codecov
Copy link

codecov bot commented May 8, 2020

Codecov Report

Merging #56 into master will increase coverage by 0.33%.
The diff coverage is 91.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
+ Coverage   74.88%   75.22%   +0.33%     
==========================================
  Files           7        7              
  Lines         442      452      +10     
==========================================
+ Hits          331      340       +9     
- Misses         80       81       +1     
  Partials       31       31              
Impacted Files Coverage Δ
internal/configmanager/configmanager.go 85.14% <91.66%> (+0.53%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 96be7fe...d9313d1. Read the comment docs.

@travisgroth travisgroth marked this pull request as ready for review May 8, 2020 11:13
@travisgroth travisgroth requested review from a team and calebdoxsey and removed request for a team May 8, 2020 11:13
@travisgroth travisgroth merged commit 3b4586e into pomerium:master May 11, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants