Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deployment: throw away golanglint-ci defaults #439

Merged
merged 2 commits into from
Jan 26, 2020

Conversation

desimone
Copy link
Contributor

@desimone desimone commented Dec 27, 2019

Summary

TIL: Asking programmers to comment their code is super duper "annoying" and only "the rare codebase has such comments".

# golint: Annoying issue about not having a comment. The rare codebase has such comments
- (comment on exported (method|function|type|const)|should have( a package)? comment|comment should be of the form)

🙄

Related issues

Checklist:

  • add related issues
  • updated docs
  • ready for review

Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
Signed-off-by: Bobby DeSimone <bobbydesimone@gmail.com>
@desimone
Copy link
Contributor Author

@travisgroth re-requesting review because I fixed the resulting lint issues.

@codeclimate
Copy link

codeclimate bot commented Jan 26, 2020

Code Climate has analyzed commit 619ae0d and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 89.3% (0.0% change).

View more on Code Climate.

@codecov
Copy link

codecov bot commented Jan 26, 2020

Codecov Report

Merging #439 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master    #439   +/-   ##
======================================
  Coverage    87.4%   87.4%           
======================================
  Files          53      53           
  Lines        2663    2663           
======================================
  Hits         2328    2328           
  Misses        255     255           
  Partials       80      80
Impacted Files Coverage Δ
internal/grpc/authorize/client/authorize_client.go 84% <ø> (ø) ⬆️
proxy/proxy.go 95.6% <ø> (ø) ⬆️
authenticate/authenticate.go 97.5% <ø> (ø) ⬆️
authorize/authorize.go 89.2% <ø> (ø) ⬆️
internal/cryptutil/certificates.go 85.7% <ø> (ø) ⬆️
internal/sessions/header/header_store.go 100% <ø> (ø) ⬆️
internal/frontend/templates.go 69.5% <ø> (ø) ⬆️
internal/encoding/mock/mock_encoder.go 100% <ø> (ø) ⬆️
internal/version/version.go 100% <ø> (ø) ⬆️
internal/tripper/roundtripper.go 100% <ø> (ø) ⬆️
... and 10 more

@desimone desimone added the docs Docs update required label Jan 26, 2020
@desimone desimone merged commit e82477e into pomerium:master Jan 26, 2020
@desimone desimone deleted the dev/fix-golang-lint-ci branch January 26, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Docs update required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants