-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unoriented sphere der #134
Unoriented sphere der #134
Conversation
e021712
to
9b7104c
Compare
9b7104c
to
6c381b1
Compare
I have conducted a series of experiments using the newly implemented derivative class, focusing on evaluating the coherence of results under different conditions of normal flipping. The parameters employed in these tests included: Three different ratios for normal flipping: 0.0, 0.25, and 0.5.
Upon analysis, I observed that there were no difference in the outcomes across the various flip ratios. |
Do you mean that your experiments validate the estimator (wrt. to those already implemented) ? |
I think @jmaleo was saying that he performed some extra tests that validates the invariance on normal directions. |
We believe there is a small error in one of the mathematical equation, I will clarify this, so this is not ready for review and merging. |
6c381b1
to
6e319b2
Compare
6e319b2
to
62254fd
Compare
Shall we undraft it and review it ? |
Yes, ready for review! |
Sounds good, can you please clean the history ? then we will be good to go I think. |
Co-authored-by: Nicolas Mellado <nmellado0@gmail.com>
491c0f7
to
0cb63e7
Compare
This PR implements de differentiation of the
UnorientedSphereFit
.Q
are now stored as class data members because they are needed by theUnorientedSphereDerImpl
derived classfit_unoriented
uses the new differentiation but only checks the coherence of the results when normal vectors are swapped. I tried to check that the curvature values are correct, but I couldn't find an appropriate epsilon value that is small enough for the comparison to work...