Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SpatialPartitioning] Force max node count type to 'std::size_t' #152

Merged
merged 2 commits into from
Oct 29, 2024
Merged

[SpatialPartitioning] Force max node count type to 'std::size_t' #152

merged 2 commits into from
Oct 29, 2024

Conversation

azaleostu
Copy link
Contributor

@azaleostu azaleostu commented Oct 23, 2024 •
edited
Loading

On MSVC, the MAX_NODE_COUNT enum value does not automatically get promoted to std::size_t when it is too big which generates an error (C4309). This PR simply forces the enum to have std::size_t as the underlying type.

@azaleostu azaleostu marked this pull request as ready for review October 23, 2024 15:19
nmellado
nmellado requested changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@nmellado nmellado left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
Please update CHANGELOG so we can merge the PR.

@nmellado nmellado merged commit aa50bfd into poncateam:master Oct 29, 2024
10 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmellado nmellado nmellado approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@azaleostu @nmellado