Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MlsSphereFitDer weight derivatives (issue #95) #97

Merged
merged 3 commits into from
Jul 7, 2023

Conversation

ThibaultLejemble
Copy link
Collaborator

Here is a quick fix to the issue #95.
The basis center is added to the local point to get back the point in global coordinates, and then call weight derivatives functions.

Small disadvantage: the basis center is added here, but then subtracted in the weight function, so it is not the most efficient solution (except if the compiler is good enough to avoid these successive additions and substractions).

@nmellado
Copy link
Contributor

Actually the bug can be simply fixed by accessing the global coordinates with attributes.pos().
The documentation should be also fixed.

@nmellado nmellado force-pushed the fix-MlsSphereFitDer branch from 38fc8f1 to 95acd9a Compare July 6, 2023 14:28
@nmellado nmellado added the bug Something isn't working label Jul 6, 2023
@nmellado nmellado force-pushed the fix-MlsSphereFitDer branch from 95acd9a to 2d19db9 Compare July 7, 2023 08:51
@nmellado nmellado merged commit 9e207cd into poncateam:master Jul 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants