Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fitting] Fix a bug in dtau computation for scale-only derivatives #98

Merged
merged 1 commit into from
Jul 6, 2023
Merged

[fitting] Fix a bug in dtau computation for scale-only derivatives #98

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Ponca/src/Fitting/gls.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ GLSDer <DataPoint, _WFunctor, DiffType, T>::dtau() const
ScalarArray dfield = Base::m_dUc;
// Recall that tau is the field function at the evaluation point, we thus must take care about
// its variation when differentiating in space:
if(this->isScaleDer())
if(this->isSpaceDer())
dfield.template tail<DataPoint::Dim>() += Base::m_ul;

return (dfield * prattNorm - Base::m_uc * cfactor * Base::dprattNorm2()) / prattNorm2;
Expand Down