Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Additional GitHub secondary rate limit failure #68

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

SeanTAllen
Copy link
Member

We previously handled secondary rate limit errors, however, it turns out that we aren't getting the exception type that we were seeing then for all secondary rate limits.

This PR updates to handle the generic "GitHubException" that PyGitHub uses. If we get the more generic error and it contains a secondary rate limit message from GitHub, we will handle with our usual "wait and try again" strategy.

We previously handled secondary rate limit errors, however, it turns
out that we aren't getting the exception type that we were seeing then
for all secondary rate limits.

This PR updates to handle the generic "GitHubException" that PyGitHub
uses. If we get the more generic error and it contains a secondary
rate limit message from GitHub, we will handle with our usual "wait
and try again" strategy.
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 16, 2024
@SeanTAllen SeanTAllen added changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge and removed discuss during sync Should be discussed during an upcoming sync labels Oct 16, 2024
@ponylang-main
Copy link
Contributor

Hi @SeanTAllen,

The changelog - fixed label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 68.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Oct 16, 2024
@SeanTAllen SeanTAllen changed the title Handle secondary rate limits that show up as "plain exceptions" Handle Additional GitHub secondary rate limit failure Oct 16, 2024
@SeanTAllen SeanTAllen requested a review from a team October 16, 2024 03:28
@SeanTAllen SeanTAllen merged commit 28b5d83 into main Oct 16, 2024
7 checks passed
@SeanTAllen SeanTAllen deleted the secondary-rate-limit branch October 16, 2024 03:29
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Oct 16, 2024
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
github-actions bot pushed a commit that referenced this pull request Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants