Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct path separator in PONYPATH on Windows #117

Merged
merged 1 commit into from
May 18, 2020
Merged

Use correct path separator in PONYPATH on Windows #117

merged 1 commit into from
May 18, 2020

Conversation

chalcolith
Copy link
Member

Fixes #116

@SeanTAllen
Copy link
Member

Standard question:

Is there a test we can add that will prevent regressions?

@chalcolith
Copy link
Member Author

The test would have to clone and try to build enough libraries that PONYPATH would be longer than 260 characters on Windows.

@SeanTAllen
Copy link
Member

That seems like overkill.

@SeanTAllen SeanTAllen added the changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge label May 15, 2020
@SeanTAllen SeanTAllen merged commit c93da7a into master May 18, 2020
@SeanTAllen SeanTAllen deleted the windows_path_sep branch May 18, 2020 01:06
github-actions bot pushed a commit that referenced this pull request May 18, 2020
@ponylang-main
Update CHANGELOG for PR #117 [skip ci]
1206c80
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SeanTAllen SeanTAllen SeanTAllen approved these changes

Assignees
No one assigned
Labels
changelog - fixed Automatically add "Fixed" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Corral PONYPATH constructor uses incorrect separator on Windows
2 participants
@chalcolith @SeanTAllen