Fixed bug where checked out code not matching revision #198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a dependency had a version constraint rather than a single value, the first time `corral update` was run, you wouldn't end up with the correct code checked out. The constraint was correctly solved, but the checked out code would be for branch `main`. The problem arose because we first have to check something out and then can do constraint solving. This commit makes the change to keep track of what "something" was that was initially checked out and if it differs from what we eventually determine the revision should be, we run another update to get the contents of `_corral` into the correct state.
SeanTAllen
added
the
changelog - changed
SeanTAllen
added
changelog - fixed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a dependency had a version constraint rather than a single value,
the first time
corral updatewas run, you wouldn't end up with thecorrect code checked out. The constraint was correctly solved, but the
checked out code would be for branch
main.The problem arose because we first have to check something out and then
can do constraint solving.
This commit makes the change to keep track of what "something" was that
was initially checked out and if it differs from what we eventually
determine the revision should be, we run another update to get the
contents of
_corralinto the correct state.