Don't error out if a transitive dependency doesn't have a corral.json #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously fetch would print a warning if a transitive dependency was missing its corral.json. By not erroring out, it made corral usable with libraries that are corral ignorant. However, update was set to error out, meaning that you couldn't use it with corral ignorant libraries. The previous version of corral switched fetch to being exactly the same as update and in the process we picked up this unwanted erroring out. This update switched update to issue a warning like fetch previously did.
SeanTAllen
added
the
changelog - fixed
jemc
approved these changes
Jul 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously fetch would print a warning if a transitive dependency was missing
its corral.json. By not erroring out, it made corral usable with libraries that
are corral ignorant. However, update was set to error out, meaning that you
couldn't use it with corral ignorant libraries.
The previous version of corral switched fetch to being exactly the same as
update and in the process we picked up this unwanted erroring out.
This update switched update to issue a warning like fetch previously did.