Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support for using ponyup on Windows #213

Merged
merged 3 commits into from
Feb 10, 2022
Merged

Conversation

chalcolith
Copy link
Member

Ponyup on Windows creates batch files in its bin directory to select the current version of its tools. This PR changes ponyc.exe in make.ps1 to ponyc, which will correctly call ponyup's batch file.

It also makes build the default command for make.ps1.

Ponyup on Windows creates batch files in its bin directory to select the current version of its tools. This PR changes `ponyc.exe` in `make.ps1` to `ponyc`, which will correctly call ponyup's batch file.

It also makes `build` the default command for `make.ps1`.
@ponylang-main ponylang-main added the discuss during sync Should be discussed during an upcoming sync label Feb 9, 2022
@chalcolith chalcolith added the do not merge This PR should not be merged at this time label Feb 9, 2022
@chalcolith chalcolith removed the do not merge This PR should not be merged at this time label Feb 9, 2022
@SeanTAllen SeanTAllen added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Feb 9, 2022
@ponylang-main
Copy link
Contributor

Hi @kulibali,

The changelog - added label was added to this pull request; all PRs with a changelog label need to have release notes included as part of the PR. If you haven't added release notes already, please do.

Release notes are added by creating a uniquely named file in the .release-notes directory. We suggest you call the file 213.md to match the number of this pull request.

The basic format of the release notes (using markdown) should be:

## Title

End user description of changes, why it's important,
problems it solves etc.

If a breaking change, make sure to include 1 or more
examples what code would look like prior to this change
and how to update it to work after this change.

Thanks.

@SeanTAllen
Copy link
Member

Once this has release notes and is merged, I'll do a corral release.

@SeanTAllen SeanTAllen merged commit e4f8d5b into main Feb 10, 2022
@SeanTAllen SeanTAllen deleted the support_windows_ponyup branch February 10, 2022 19:22
@ponylang-main ponylang-main removed the discuss during sync Should be discussed during an upcoming sync label Feb 10, 2022
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
github-actions bot pushed a commit that referenced this pull request Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants