-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix resolving relative paths with corral run
#216
Conversation
…ent folders Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
So the path you gave was valid but it wasn't run? I'm confused by the explanation. |
The path was valid and existing and runnable. The code to resolve relative paths had a flaw in that it used FilePath.from which errors when one tries to escape that path upwards using |
Gotcha |
Would you agree this is two changes? If yes, then please add one manually to change log and add two release notes entries. Then add a correct changelog label to this PR and rename the PR to match whatever the automatically added changelog entry should be. We need a bot added changelog as without a changelog label, release notes are ignored. |
corral run
@mfelsche this needs a changelog entry manually added for the |
ye'ole backslashes...
Co-authored-by: Sean T Allen <sean@seantallen.com>
Co-authored-by: Sean T Allen <sean@seantallen.com>
Co-authored-by: Sean T Allen <sean@seantallen.com>
…into corral-run-fixes
The logic to determine the absolute path to an executable was using
FilePath.from(base, subdir)
which errors if the resulting path is not below thebase
. This is the case ifsubdir
is e.g.../foo
.This fix stems from trying to execute:
The error output is clearly not really informative.
With this PR the above command actually runs the existing ponyc.
Other changes in here all related to improving
corral run
:$PATH
. This enables running relative paths to parent folders (See the above command).