-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade and swap of dependencies, huge Refactoring #4
Conversation
E.g. go fully async without explicitly using threads. Use axum instead of rocket. Still WIP.
Signed-off-by: Matthias Wahl <matthiaswahl@m7w3.de>
I'm not qualified to review this. Personally, I put faith in you on it @mfelsche. Is there anyone you want to review this? |
@mfelsche if no one weighs in on this by/during sync on the 15th, are you ok with having this merged sans any other eyes? |
I am totally fine with this being merged without anyone else having a look at this. But then you gotta trust me, that everything is fine with this PR and no one is going to mine bitcoins with this. |
I'm not knowledgeable enough about Rust to comment on the code, but I tried this PR locally and everything seems to work fine. |
This wasn't covered in the sync call, but I think this should be good to merge. On my quick, unexpert review, everything looked fine. Do you agree @mfelsche ? |
This doesn't work in prod. |
I know this is a huge PR and it has lots of stuff smooshed together. But it is an improvement in both code quality and recency of dependencies. It should also give a really small performance improvement. I would appreciate feedback from anyone with a Rust background and welcome all questions from anyone without.
The dependency on my fork of octocrab will be removed, once gist update support is merged upstream and released. I will take care of maintaining that dependency.
From local testing i can verify that the steps for installation and deployment are still the same. Nothing changed on the administrative side here.
All existing functionality still exists.
This PR can be easily verified locally with a
rustup
installation and a personalGITHUB_TOKEN
.