Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RFC: TCP must be connected #1310

Closed
SeanTAllen opened this issue Oct 12, 2016 · 3 comments
Closed

RFC: TCP must be connected #1310

SeanTAllen opened this issue Oct 12, 2016 · 3 comments
Assignees
@drannise

Comments

@SeanTAllen
Copy link
Member

Verify TCP Connections are open before allowing data to be written.

https://github.com/ponylang/rfcs/blob/master/text/0016-tcp-must-be-connected.md
@drannise
Copy link
Contributor

Hi Sean,

This looks simple enough even for me. I'll try this to get familiar with the contribution process if you don't mind.

@SeanTAllen
Copy link
Member Author

SeanTAllen commented Oct 12, 2016 •
edited
Loading

Awesome @drannise.

This change would require an addition to the CHANGELOG plus, make sure you don't overlook the "How to teach this" requirements. They are small but important.

I invited you to the org so you can be assigned to the issue. Just drop me a note here when you accept.

Have a look at https://github.com/ponylang/ponyc/blob/master/CONTRIBUTING.md if you haven't already. Particularly "how to write a good commit message". Its particular important for this one (as it is referenced as something to do as part of the "How to teach this".

Feel free to steal from the RFC summary and motivation for the commit comment as well as including a link to https://github.com/ponylang/rfcs/blob/master/text/0016-tcp-must-be-connected.md if you want.

@jemc jemc assigned jemc and drannise and unassigned jemc Oct 12, 2016
@jemc
Copy link
Member

jemc commented Oct 12, 2016

I noticed @drannise has accepted the invite and took the liberty of assigning the ticket (after accidentally assigning myself 😝).

drannise added a commit to drannise/ponyc that referenced this issue Oct 19, 2016
@drannise
Verify TCP Connections are open before allowing data to be written.
be6cdcd 
Prevent subtle bugs and potential runaway memory usage that can be introduced by being unfamiliar with the internals of the `TCPConnection` class.

As a result of this change when writing to the connection data will be silently discarded if the connection has not yet been established.

Resolves: ponylang#1310
See also: https://github.com/ponylang/rfcs/blob/master/text/0016-tcp-must-be-connected.md
@drannise drannise mentioned this issue Oct 19, 2016
Merged
drannise added a commit to drannise/ponyc that referenced this issue Oct 19, 2016
@drannise
Verify TCP Connections are open before allowing data to be written.
7c6f080 
Prevent subtle bugs and potential runaway memory usage that can be introduced by being unfamiliar with the internals of the `TCPConnection` class.

As a result of this change when writing to the connection data will be silently discarded if the connection has not yet been established.

Resolves: ponylang#1310
See also: https://github.com/ponylang/rfcs/blob/master/text/0016-tcp-must-be-connected.md
SeanTAllen pushed a commit that referenced this issue Jan 10, 2017
@drannise @SeanTAllen
Verify TCP Connections are open before allowing data to be written. (#…
74555f7 
…1341)

Prevent subtle bugs and potential runaway memory usage that can be introduced by being unfamiliar with the internals of the `TCPConnection` class.

As a result of this change when writing to the connection data will be silently discarded if the connection has not yet been established.

Resolves: #1310
See also: https://github.com/ponylang/rfcs/blob/master/text/0016-tcp-must-be-connected.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@drannise drannise

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@drannise @SeanTAllen @jemc