Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Method chaining (RFC #25) #1411

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Method chaining (RFC #25) #1411

merged 1 commit into from
Nov 11, 2016

Conversation

Praetonus
Copy link
Member

This change provides a way to chain calls on an object without depending on the method's API.

Closes #1409.

@SeanTAllen
Copy link
Member

Woo hoo!

@SeanTAllen
Copy link
Member

Is there documentation updates with this? Tutorial changes for example? I dont think we should merge wo corresponding documentation being ready.

@Praetonus
Copy link
Member Author

The RFC says this:

In the tutorial there will be a new section under "Methods" that motivates and explains this syntax.

@jemc
Copy link
Member

jemc commented Nov 10, 2016

Can we get some compiler tests that demonstrate the compiler errors received when you get the caps wrong?

That is, we have compiler tests for constructs like automatic receiver recovery that show/prove which kinds of situations where the receiver can or can't be recovered. I think having some similar tests in place for the new semantics of this change will be pretty critical.

@Praetonus
Copy link
Member Author

@jemc I'll add that.

@SeanTAllen
Copy link
Member

@Praetonus that tutorial update is in the works?

@Praetonus
Copy link
Member Author

@SeanTAllen Yes, I'll do a PR.

@Praetonus
Copy link
Member Author

Tests added.

@Praetonus Praetonus added the changelog - added Automatically add "Added" CHANGELOG entry on merge label Nov 10, 2016
@Praetonus
Copy link
Member Author

Tutorial PR submitted: ponylang/pony-tutorial#167

Add method chaining (RFC ponylang#25)
4c8e94c 
This change provides a way to chain calls on an object without
depending on the method's API.

Closes ponylang#1409.
@Praetonus
Copy link
Member Author

I've fixed an assertion check that was wrongly considering tag chains on iso objects as incorrect because auto-recovery isn't checked on tag methods.

@jemc jemc merged commit 59f44c2 into ponylang:master Nov 11, 2016
ponylang-main added a commit that referenced this pull request Nov 11, 2016
@ponylang-main
Update CHANGELOG for PR #1411
586141c
@jemc jemc mentioned this pull request Nov 11, 2016
Closed
@Praetonus Praetonus deleted the chaining branch July 8, 2017 03:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jemc jemc jemc approved these changes

Assignees
No one assigned
Labels
changelog - added Automatically add "Added" CHANGELOG entry on merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Praetonus @SeanTAllen @jemc