Always call finalisers for embedded fields #1586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Praetonus
added
the
changelog - fixed
jemc
reviewed
Feb 14, 2017
src/libponyc/codegen/genfun.c
Outdated
| @@ -295,6 +321,9 @@ static bool genfun_fun(compile_t* c, reach_type_t* t, reach_method_t* m) | |||
| codegen_startfun(c, m->func, m->di_file, m->di_method); | |||
| name_params(c, t, m, params, m->func); | |||
|
|
|||
| if(m->func == t->final_fn) | |||
| call_embed_finalisers(c, t, LLVMGetParam(codegen_fun(c), 0)); | |||
There was a problem hiding this comment.
What do you think about using gen_this instead of LLVMGetParam(..., 0)? Since we already have that abstraction available, it seems prudent to try to use it wherever possible, and avoid depending on the order of params here.
There was a problem hiding this comment.
Seems reasonable. I'll update the PR.
Previously, finalisers of embedded fields would never be called due to embedded fields being transparent to the runtime. This change adds calls to the adequate finalisers in parent objects' finalisers when said parents contain embedded fields. Closes ponylang#1551.
Praetonus
force-pushed
the
embed-final
branch
from
9df9734 to
bb9ce86
Compare
jemc
approved these changes
Feb 14, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, finalisers of embedded fields would never be called due to embedded fields being transparent to the runtime. This change adds calls to the adequate finalisers in parent objects' finalisers when said parents contain embedded fields.
Closes #1551.